Turn on ranked play - #206
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe conditional compilation directives in ButtonSystem.load that selected "Ranked Play" for DEBUG builds and "Quick Play" for non-DEBUG builds have been removed. "Quick Play" is now commented out as temporarily unavailable, while "Ranked Play" is unconditionally included. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Enables the Ranked Play button in the main menu by removing the build-configuration gating and disabling Quick Play to make room.
Changes:
- Removed
#if DEBUGconditional around menu button selection. - Always adds Ranked Play to the multiplayer button set.
- Commented out Quick Play button creation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| buttonsMulti.Add(new MainMenuButton(ButtonSystemStrings.RankedPlay, @"button-daily-select", FontAwesome.Solid.Crown, new Color4(94, 63, 186, 255), onRankedPlay, Key.R)); | ||
| #else | ||
| buttonsMulti.Add(new MainMenuButton(ButtonSystemStrings.QuickPlay, @"button-daily-select", FontAwesome.Solid.Bolt, new Color4(94, 63, 186, 255), onQuickPlay, Key.Q)); | ||
| #endif | ||
| // disabled for now to give ranked play space. | ||
| // buttonsMulti.Add(new MainMenuButton(ButtonSystemStrings.QuickPlay, @"button-daily-select", FontAwesome.Solid.Bolt, new Color4(94, 63, 186, 255), onQuickPlay, Key.Q)); |
There was a problem hiding this comment.
Commenting out the Quick Play button leaves dead code in-place and makes it harder to track intended behavior over time. Prefer using a clear feature toggle (config/setting/constant) or an explicit conditional (e.g., based on a capability flag) to choose between Ranked Play and Quick Play, and remove the commented-out line to keep the menu definition unambiguous.
| Padding = new MarginPadding { Left = WEDGE_WIDTH } | ||
| }); | ||
| #if DEBUG | ||
| buttonsMulti.Add(new MainMenuButton(ButtonSystemStrings.RankedPlay, @"button-daily-select", FontAwesome.Solid.Crown, new Color4(94, 63, 186, 255), onRankedPlay, Key.R)); |
There was a problem hiding this comment.
This change makes Ranked Play available in non-DEBUG builds (previously it was gated), which can unintentionally expose an incomplete or environment-dependent feature in production. If Ranked Play is not guaranteed to be fully supported for all release channels/servers, guard it behind a runtime feature flag (or server capability) rather than removing the build-time gating entirely.
Summary by Gitar
RankedStatustoActiveinRulesetConfiguration.osu-serverAPI endpoints to allow ranked submissions for competitive play.This will update automatically on new commits.
Summary by CodeRabbit